commit | 95bd98e0414c8d6fbddedb09ad40dcd6db3dc306 | [log] [tgz] |
---|---|---|
author | Lei Zhang <thestig@chromium.org> | Mon Mar 04 21:41:38 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Mar 04 21:41:38 2019 |
tree | 73efdcd2c36319cb2bc1df0e2bd8b5c3138c65b4 | |
parent | a35ca854f381f05628588f5e231a50588b02bcff [diff] |
Avoid an early start up crash in base::win::OSInfo. r633961 tries to get the system architecture in Crashpad code. This gets called very early during process start up and relies on base::win::OSInfo. base::win::OSInfo gathers many different pieces of information about the OS, but crashes as used from Crashpad, possibly because of Windows registry access in a sandboxed process. Avoid this issue by splitting base::win::OSInfo::architecture() out into a static GetArchitecture() method. GetArchitecture() does the minimal amount of work necessary to get the system architecture. BUG=937840 Change-Id: I174ef78494dcf804f8f4bb1e3a7a25d9c0e37c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499730 Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637432}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .