Google Git
Sign in
chromium / chromium / src / 96fa6c14aa7e7e8902d6cb703ea2502e0c13215c
commit96fa6c14aa7e7e8902d6cb703ea2502e0c13215c[log] [tgz]
authorBill Orr <billorr@chromium.org>Wed Jan 16 18:27:27 2019
committerCommit Bot <commit-bot@chromium.org>Wed Jan 16 18:27:27 2019
treee5650f95baf6ef2329fce0ebcb44aedfc93df596
parentf86f976a75aa04a230462ecad2249d5c2f50c634 [diff]
Fix a crash in VRBrowserRendererThreadWin

VRBrowserRendererThreadWin behaved as though it lived on a separate
thread, posting tasks to do work instead of doing the work
synchronously.  If it was destroyed, those posted tasks would still run,
potentially using VRBrowserRendererThreadWin or its members after
destruction.

The fix is to stop pretending it is a thread, avoiding the posted tasks.

BUG=921739

Change-Id: I147cccf9487386b95c25401d444294321fa925af
Reviewed-on: https://chromium-review.googlesource.com/c/1413413
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623303}
3 files changed
tree: e5650f95baf6ef2329fce0ebcb44aedfc93df596
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .