commit | 99389e73d775269063c12390bb3b002545938e5d | [log] [tgz] |
---|---|---|
author | Kevin Marshall <kmarshall@chromium.org> | Tue Feb 05 00:29:49 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 05 00:29:49 2019 |
tree | cd9ed96dbad1f4b7bcd07b43aa123d4d3e72be2c | |
parent | 974b8ae7cea90953e1a1f8d27f56c7ca39a84a3a [diff] |
Revert "Have jumbo dump the original sources in the gn |data| variable" This reverts commit 08fc084679b0787e1349fc92fa7a062fa2f5b99d. Reason for revert: Breaks Fuchsia jumbo builds. Fuchsia package generation uses a target's runtime data to determine which files should be included. This CL adds a lot of source .cc and .h files to the runtime data, which breaks the package building process. dpranke@ suggests placing this CL's workaround inside a GN flag such as "include_jumbo_in_analyze", so that it doesn't affect existing jumbo build users. Original change's description: > Have jumbo dump the original sources in the gn |data| variable > > Jumbo, as implemented as a gn template, will naturally hide > the original files behind new files target_jumbo_1.cc, > target_jumbo_2.cc, .... This breaks the gn analyze step which is > used by cq to figure out if it needs to test compile or not. > > There might be unexpected and unwanted side effects from this. > The cleanest solution would be to give gn native jumbo support > which would also allow other changes like better IDE support > and better error messages, but this is what we got. > > Bug: 893071 > Change-Id: Ibbe8ccd71c932ca4c28c3157e386530d1ae00965 > Reviewed-on: https://chromium-review.googlesource.com/c/1268336 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Daniel Bratell <bratell@opera.com> > Cr-Commit-Position: refs/heads/master@{#628598} TBR=brettw@chromium.org,dpranke@chromium.org,bratell@opera.com,mostynb@vewd.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 893071 Change-Id: Iac7444dddc37cb33c9ba20e3423c95a74ef870fa Reviewed-on: https://chromium-review.googlesource.com/c/1453098 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#628960}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .