Google Git
Sign in
chromium / chromium / src / 9951e506d3c13c9415a3bb3d9999cf58d4699d08
commit9951e506d3c13c9415a3bb3d9999cf58d4699d08[log] [tgz]
authormrefaat <mrefaat@chromium.org>Wed Mar 06 08:01:27 2019
committerCommit Bot <commit-bot@chromium.org>Wed Mar 06 08:01:27 2019
tree7452f93e6b6ef34fe7d792b04daf43b31512be96
parent9657b4f857cb37693227339b3e113a52f752a5b8 [diff]
Create U2F tab helper and remove U2F related methods from Tab class

Made U2FController more of implementation details. with U2FTabHelper as the
public class to be used.
Added tests to U2FTabHelperTest to test the javascript execution. instead of mocking the method (was mocked in
u2f_controller_unittest). Also simplified all the existing unit tests.


Bug: 902048
Change-Id: Ife7ac7605bb7bb0e236095dd42871152ea696cfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487180
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638044}
15 files changed
tree: 7452f93e6b6ef34fe7d792b04daf43b31512be96
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .