commit 9b58eaed9d581d271d15449aed9b855bcd7cb410
author Robert Ogden <robertogden@chromium.org> Tue Feb 12 01:18:43 2019
committer Commit Bot <commit-bot@chromium.org> Tue Feb 12 01:18:43 2019
tree dd8f7abd9e5364ecfd7f084d72502ae4d1835006
parent 18e1008abc72e6d9df76ecc2e7538c9a309dbc80

Disable highlight for Previews IPH

I added a helper method for this to allow for easier changes like this
down the road, if wanted for other features.

Bug: 930877
Change-Id: Iad809f2e94e85db57e661f610ce63be9619a2dff
Reviewed-on: https://chromium-review.googlesource.com/c/1465062
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631027}

chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java
index f76272f2..38ad662 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java
@@ -174,6 +174,15 @@
                         accessibilityStringId, anchorView, appMenuHandler, activity));
     }
 
+    private static boolean shouldHighlightForIPH(String featureName) {
+        switch (featureName) {
+            case FeatureConstants.PREVIEWS_OMNIBOX_UI_FEATURE:
+                return false;
+            default:
+                return true;
+        }
+    }
+
     private static void maybeShowIPH(Tracker tracker, String featureName,
             Integer highlightMenuItemId, @StringRes int stringId,
             @StringRes int accessibilityStringId, View anchorView, AppMenuHandler appMenuHandler,
@@ -202,10 +211,14 @@
             textBubble.setDismissOnTouchInteraction(true);
             textBubble.addOnDismissListener(() -> anchorView.getHandler().postDelayed(() -> {
                 tracker.dismissed(featureName);
-                turnOffHighlightForTextBubble(appMenuHandler, anchorView);
+                if (shouldHighlightForIPH(featureName)) {
+                    turnOffHighlightForTextBubble(appMenuHandler, anchorView);
+                }
             }, ViewHighlighter.IPH_MIN_DELAY_BETWEEN_TWO_HIGHLIGHTS));
 
-            turnOnHighlightForTextBubble(appMenuHandler, highlightMenuItemId, anchorView);
+            if (shouldHighlightForIPH(featureName)) {
+                turnOnHighlightForTextBubble(appMenuHandler, highlightMenuItemId, anchorView);
+            }
 
             int yInsetPx = activity.getResources().getDimensionPixelOffset(
                     R.dimen.text_bubble_menu_anchor_y_inset);