commit | 9d7ba34e9ad8af99e9b57ba680d2778d016829ae | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Wed Mar 13 04:42:49 2019 |
committer | Findit <findit-for-me@appspot.gserviceaccount.com> | Wed Mar 13 04:42:49 2019 |
tree | 3e0367c8265b1575bd11de33b7a09f91923d2bae | |
parent | a72b4c08b34245ae99147426b98799bd51e6dd15 [diff] |
Revert "Links and docs with just one image inside should get annotated." This reverts commit b8da3f9a6fd6f77c140ddbcc8aa9244a1fbcf529. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 639835 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYjhkYTNmOWE2ZmQ2Zjc3YzE0MGRkYmNjOGFhOTI0NGExZmJjZjUyOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/50176 Sample Failed Step: browser_tests Sample Flaky Test: ImageAnnotationBrowserTest.ImagesInLinks Original change's description: > Links and docs with just one image inside should get annotated. > > There were cases where no annotation was being read for an image > inside of a link, depending on the exact syntax and the platform > and screen reader. In addition, some screen readers weren't > reading the image annotation when opening an image by itself in > a tab. > > Address both of these by having a rootWebArea or link get the > annotation of its inner image, when it has exactly one inner > image and no other text or object with a name inside. > > Bug: 940043 > Change-Id: Ic3283e6f8ea26f1ec9ed1cb1203800cd44a49a00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512916 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Katie Dektar <katie@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639835} Change-Id: I94a23c0db273b554ba2586d1a6165993faffb3fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 940043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519933 Cr-Commit-Position: refs/heads/master@{#640194}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .