commit | 9e25ff8af438a32bdb360f11017f4df07cad9e0b | [log] [tgz] |
---|---|---|
author | Xiaocheng Hu <xiaochengh@chromium.org> | Tue Feb 05 18:28:15 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 05 18:28:15 2019 |
tree | 4f01c36eb9f94250322ba2dd0b60004700951357 | |
parent | 91ed4731e5bebfc550db842a30667ae84cfcc888 [diff] |
Reland "[LayoutNG] Work around crash with 'text-transform'" This reverts commit 3b81a4d7142d0a1061a6a3c862040fabc44fab6d. Reason for reland: The test is expected not to pass with legacy layout. The missing Failure expectation is now added. Original change's description: > Revert "[LayoutNG] Work around crash with 'text-transform'" > > This reverts commit acdd73ae91dbf0374427501eb9c00c89e0a40978. > > Reason for revert: editing/selection/mouse/drag_over_text_transform.html fails on mac > > > Bug: 928739 > > Original change's description: > > [LayoutNG] Work around crash with 'text-transform' > > > > 'text-transform' may make LayoutText::GetText() longer than the original > > DOM text node, and result in out-of-range offsets that are not properly > > handled. > > > > This patch works around that in some crash sites so that it stops > > crashing. > > > > Bug: 899868 > > Change-Id: I55645b83b3d2d0aec38cb2c0f97a2b89a4897d3e > > Reviewed-on: https://chromium-review.googlesource.com/c/1450745 > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#628916} > > TBR=yosin@chromium.org,eae@chromium.org,yoichio@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > Change-Id: I3aa66f79939a3fd32760db28f3832c31b67a24ae > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 899868 > Reviewed-on: https://chromium-review.googlesource.com/c/1454581 > Reviewed-by: Florent Castelli <orphis@chromium.org> > Commit-Queue: Florent Castelli <orphis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629131} TBR=yosin@chromium.org,eae@chromium.org,yoichio@chromium.org,kojii@chromium.org,xiaochengh@chromium.org,orphis@chromium.org Change-Id: I17fd5b584b35ad8d2f5fec4d62c2868d87de176d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928739, 899868 Reviewed-on: https://chromium-review.googlesource.com/c/1455022 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#629228}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .