IWYU: usage of base::flat_map requires declaration of key and values in AggregationKeys

Fix build issue with libstdc++, as base::flat_map uses internally
std::pair, and the libstdc++ implementation requires full declaration
of the two contained types in pair.

Build error is:
    /usr/include/c++/12/bits/stl_pair.h: In instantiation of ‘struct std::pair<std::__cxx11::basic_string<char>, absl::uint128>’:
    /usr/include/c++/12/bits/stl_vector.h:1084:24:   required from ‘constexpr bool std::vector<_Tp, _Alloc>::empty() const [with _Tp = std::pair<std::__cxx11::basic_string<char>, absl::uint128>; _Alloc = std::allocator<std::pair<std::__cxx11::basic_string<char>, absl::uint128> >]’
    ../../base/containers/flat_tree.h:709:21:   required from ‘constexpr bool base::internal::flat_tree<Key, GetKeyFromValue, KeyCompare, Container>::empty() const [with Key = std::__cxx11::basic_string<char>; GetKeyFromValue = base::internal::GetFirst; KeyCompare = std::less<void>; Container = std::vector<std::pair<std::__cxx11::basic_string<char>, absl::uint1
    28>, std::allocator<std::pair<std::__cxx11::basic_string<char>, absl::uint128> > >]’
    ../../components/attribution_reporting/source_registration.cc:159:37:   required from here
    /usr/include/c++/12/bits/stl_pair.h:192:11: error: ‘std::pair<_T1, _T2>::second’ has incomplete type
      192 |       _T2 second;                ///< The second member
          |           ^~~~~~
    In file included from ../../components/attribution_reporting/source_registration.h:15:
    ../../components/attribution_reporting/aggregation_keys.h:18:7: note: forward declaration of ‘class absl::uint128’
       18 | class uint128;
          |       ^~~~~~~

Bug: 957519
Change-Id: If3db4a7b3dff76687f6c5b00a2b687c569b47249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334264
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1116385}
2 files changed
tree: 94c59734ad08388ccbf0e90a369d167973508b1e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.