commit | 9e7aa9f5355575051bb0bd359ed1634d7b1285e2 | [log] [tgz] |
---|---|---|
author | Jose Dapena Paz <jdapena@igalia.com> | Mon Mar 13 15:27:07 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 13 15:27:07 2023 |
tree | 94c59734ad08388ccbf0e90a369d167973508b1e | |
parent | 92821084d61bd7009172bd3b53a93a11d50cec02 [diff] |
IWYU: usage of base::flat_map requires declaration of key and values in AggregationKeys Fix build issue with libstdc++, as base::flat_map uses internally std::pair, and the libstdc++ implementation requires full declaration of the two contained types in pair. Build error is: /usr/include/c++/12/bits/stl_pair.h: In instantiation of ‘struct std::pair<std::__cxx11::basic_string<char>, absl::uint128>’: /usr/include/c++/12/bits/stl_vector.h:1084:24: required from ‘constexpr bool std::vector<_Tp, _Alloc>::empty() const [with _Tp = std::pair<std::__cxx11::basic_string<char>, absl::uint128>; _Alloc = std::allocator<std::pair<std::__cxx11::basic_string<char>, absl::uint128> >]’ ../../base/containers/flat_tree.h:709:21: required from ‘constexpr bool base::internal::flat_tree<Key, GetKeyFromValue, KeyCompare, Container>::empty() const [with Key = std::__cxx11::basic_string<char>; GetKeyFromValue = base::internal::GetFirst; KeyCompare = std::less<void>; Container = std::vector<std::pair<std::__cxx11::basic_string<char>, absl::uint1 28>, std::allocator<std::pair<std::__cxx11::basic_string<char>, absl::uint128> > >]’ ../../components/attribution_reporting/source_registration.cc:159:37: required from here /usr/include/c++/12/bits/stl_pair.h:192:11: error: ‘std::pair<_T1, _T2>::second’ has incomplete type 192 | _T2 second; ///< The second member | ^~~~~~ In file included from ../../components/attribution_reporting/source_registration.h:15: ../../components/attribution_reporting/aggregation_keys.h:18:7: note: forward declaration of ‘class absl::uint128’ 18 | class uint128; | ^~~~~~~ Bug: 957519 Change-Id: If3db4a7b3dff76687f6c5b00a2b687c569b47249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334264 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/main@{#1116385}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.