commit | 3b39a541429c5031a7a7d12d13ade6fd69a10356 | [log] [tgz] |
---|---|---|
author | Patrik Höglund <phoglund@chromium.org> | Fri Nov 09 12:39:32 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Nov 09 12:39:32 2018 |
tree | 4245f7d2774a375726a9b926fae5bce394a2987c | |
parent | 24599fc67d36d611bdde3dc74d2f069491c7b9ca [diff] |
Revert "Don't make a LayerTreeFrameSink for a non-visible RenderWidget." This reverts commit 68d8dbc019fd37659252e273ade868aac7a9d8ac. Reason for revert: Looks like it makes PrerenderBrowserTest.PrerenderInfiniteLoop according to FindIt. ../../chrome/browser/prerender/prerender_browsertest.cc:1721: Failure Expected equality of these values: 1U Which is: 1 GetLinkPrerenderCount() Which is: 2 Original change's description: > Don't make a LayerTreeFrameSink for a non-visible RenderWidget. > > Importantly, non-visible RenderWidgets include swapped out RenderWidgets > which are zombies, without a frame, and which should not be used. > > This can happen if the RenderWidget swap out races with the posted task > from the compositor to make a LayerTreeFrameSink. When swapping out, the > compositor would be marked as not-visible, which would stop it from > making such requests, but one could already be in flight. > > In the other case, honoring the request for a non-visible compositor is > more benign, but we can delay it until the compositor is actually > visible again. This means if a context is lost, backgrounded tabs would > not all attempt to reconnect to the Gpu process at once. > > This is a better followup for the hacky > https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which > was meant only for merge to a release branch. It reverts that change as > part of this one. > > R=piman@chromium.org > > Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7 > Bug: 896836, 419087 > Reviewed-on: https://chromium-review.googlesource.com/c/1292714 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606655} TBR=danakj@chromium.org,dcheng@chromium.org,piman@chromium.org Change-Id: I65238aba0abdb6c9192e9f3cb3691f8dd89b3ea5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896836, 419087, 903696 Reviewed-on: https://chromium-review.googlesource.com/c/1329003 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606807}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .