commit | a0e5541641b1c252ce6e7fc4d1cb6a2a454abfba | [log] [tgz] |
---|---|---|
author | Yi Gu <yigu@chromium.org> | Thu Jan 17 01:52:44 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 17 01:52:44 2019 |
tree | 46ae50c3d8e64c059271760228d996b80f9b554b | |
parent | 30faaba26cc0fa9230e482b1fab778fab111fa87 [diff] |
Reland "[Animation Worklet] Throw upon constructing WorkletAnimation for unregistered animator" This reverts commit 304e0d5a9053b04bef7e4f277aae0aa6e5ce785a. Reason for revert: The revert was in build 30164 but the memory leak was gone before that. [1] The reverted patch actually didn't touch the path that was in the crash report. [1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Leak%20Detection%20Linux?limit=200 Original change's description: > Revert "[Animation Worklet] Throw upon constructing WorkletAnimation for unregistered animator" > > This reverts commit b48a21c421756109b23f9cb9c639be6c48d371a0. > > Reason for revert: Memory leaks, see crbug.com/875262 > > Original change's description: > > [Animation Worklet] Throw upon constructing WorkletAnimation for unregistered animator > > > > Currently the WorkletAnimation construction silently fails if the > > animator has not yet been registered. Similar to AudioWorklet, the > > proper way of handling such scenario is throwing an exception. > > > > Bug: 875262 > > Change-Id: I1be22f1b8c07b5e83b4071b92a70f991449874a5 > > Reviewed-on: https://chromium-review.googlesource.com/c/1403930 > > Commit-Queue: Yi Gu <yigu@chromium.org> > > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#622741} > > TBR=jbroman@chromium.org,majidvp@chromium.org,yigu@chromium.org > > Change-Id: I23ef3c2bb7d3605f17b8be5fdbc447dc2b9401c2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 875262 > Reviewed-on: https://chromium-review.googlesource.com/c/1411334 > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622781} TBR=battre@chromium.org,jbroman@chromium.org,majidvp@chromium.org,yigu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875262 Change-Id: I108089ad956f31c920a352608553d374cc677e89 Reviewed-on: https://chromium-review.googlesource.com/c/1415831 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#623507}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .