tree 085cd332b3a625b4b6be95915b84205dbb7bc93a
parent 4b2b942138b01662238ee1ed1d711eb80373708b
author Manuel Rego Casasnovas <rego@igalia.com> 1584943909 +0000
committer Commit Bot <commit-bot@chromium.org> 1584943909 +0000

Fix ellipsis position for RTL elements

In ShapeResult::OffsetToFit() when the size to fit
matches result.origin_x we were returning
the left_character_index only if Direction() was RTL.
However if line_direction is RTL we also want that index.

With this change css/css-ui/text-overflow-028.html starts to pass
on Linus and Windows, we add new tests here too
(the RTL ones were failing before this patch).

BUG=1063319
TEST=css/css-overflow/text-overflow-ellipsis-001.html
TEST=css/css-overflow/text-overflow-ellipsis-rtl-001.html
TEST=css/css-overflow/text-overflow-ellipsis-vertical-001.html
TEST=css/css-overflow/text-overflow-ellipsis-vertical-ltr-001.html

Change-Id: Idbaed07a63d4ec6335e722b7fb7b4e91f4076564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111152
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#752380}