commit a181995ae3af099f20974710d90d1558d635a5eb
author Mark Pearson <mpearson@chromium.org> Tue Nov 13 22:40:27 2018
committer Commit Bot <commit-bot@chromium.org> Tue Nov 13 22:40:27 2018
tree 3aed5ae705b1b55267f8b096193c8ca20102b54e
parent b5888d39c8a91df48d327de6c059c2b6504e80e5

Revert "Refactor SearchProviderTest.SendsWarmUpRequestOnFocus to Deflake It"

This reverts commit 6111392df90a20002baa8d04ab06cf4e8fb8b0e7.

Refactoring did do something, but the issue remained.  The core problem
I think is that the parent class fields are initialized first.  This
means the parent class's fields like content::TestBrowserThreadBundle
get created, which I think will end up looking at field trial state.
Adding a base::test::ScopedFeatureList after that happens is too late;
the initial field trial state has already been inspected.

I could create a separate class that lists the base::test::ScopedFeatureList
first, and then all the other variables such as TestBrowserThreadBundle
later.  That might work.  Or not; I think there are other reasons the
TestBrowserThreadBundle wants to be listed first in the fields of a testing
class.

It's not worth the trouble to investigate.  I'm happy to have coverage
of the single MAYBE_ test on regular bot.  I don't think we also need
coverage of it on the ASAN (THREAD_SANITIZER) bots as well.

Bug: 891959
Change-Id: Iae816dde484982060121c3e667b779d70da00e65
Reviewed-on: https://chromium-review.googlesource.com/c/1334269
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607776}