splitview: More on indicator label animation parameters after CL 1509813.

When an indicator label fades in or out, the correct animation
parameters depend upon whether the corresponding indicator is
expanding/contracting or just also fading in or out. Currently,
SplitviewAnimationType has separate values for these cases, but calls to
DoSplitviewOpacityAnimation() show confusion over the distinction. Also,
ApplyAnimationSettings() does not correctly handle the case where an
opacity animation and a transform animation should be both delayed
simultaneously, on the same layer. I am fixing both problems in the
present CL.

Test: manual
Bug: 943718
Change-Id: Idc68e80c382bdefca7658c5a3050a55c5bbc8c06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533097
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643399}
2 files changed