commit a365352b71a3cfd867a6773d0a2d9c386fd5680f
author Jacob Dufault <jdufault@google.com> Tue Feb 05 19:38:02 2019
committer Commit Bot <commit-bot@chromium.org> Tue Feb 05 19:38:02 2019
tree 1d8e4a7fbebcc9e5a93ca31e3c0fb719049fa644
parent a445df3dabbf03b3b2b7cf1e70d93e3278335d0f

cros: Simplify how views/screens are mocked in WizardControllerBrowsertest

This eliminates MockOutShowHide and simplifies lifetime.

MockOutShowHide derived from another Mock class, and also embedded the
view inside of it. This means that the view was destroyed while the
model was being destroyed.

EXPECT_* methods are now moved to test code instead of the mock class,
since the EXPECT_* methods assume a specific type of usage that is not
always present.

ScreenManager is also cleaned up so that it does not declare any friend
tests.

Bug: 928555
Change-Id: I2f61648dc980e4d5b08620d76d3bbd4d58cd2403
Reviewed-on: https://chromium-review.googlesource.com/c/1450281
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629264}