Not all alerts should not have a bug created for them. Please read on...
&num_points=XXXX
with &rev=COMMIT_POSITION
in the URL.//tools/binary_size/diagnose_bloat.py
to build all commits locally and find the culprit.Example:
tools/binary_size/diagnose_bloat.py AFTER_GIT_REV --reference-rev BEFORE_GIT_REV --subrepo v8 --all
git log --format=fuller
(be sure to look at CommitDate
and not AuthorDate
)diagnose_bloat.py
(with --subrepo=clank
).If the code clearly justifies the size increase, silence the alert.
Otherwise, file a bug (TODO: Make this template automatic):
X%
to XXkb
Caused by “First line of commit message”
Commit: abc123abc123abc123abc123abc123abc123abcd
Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=480214
Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase
Based on the graph: 20kb of native code, 8kb of pngs.
Option 1:
It looks to me that the size increase is expected.
Feel free to close as “Won't Fix” unless you can see some way to reduce size.Option 2:
It looks like this increase was probably unexpected or might be avoidable.
Please have a look and either:
- Close as “Won't Fix” with a short justification, or
- Land a revert / fix-up.
Option 3:
It's not clear to me whether or not this increase was expected.
Please have a look and either:
- Close as “Won't Fix” with a short justification, or
- Land a revert / fix-up.
If you went with Option 2, and the regression is > 50kb, add ReleaseBlock-Stable M-6- (next branch cut).
Once the initial bug is filed, add a follow-up comment with the output of:
tools/binary_size/diagnose_bloat.py GIT_REV --cloud
Figure out which file within the .apk
increased (native library, dex, pak resources, etc) by looking at the breakdown in the size graphs linked to in the bug (if it was not linked in the bug, see above).
Won't Fix
.compress="gzip"
is used for all chrome:
pages.--cloud
option. E.g.:tools/binary_size/diagnose_bloat.py 0f30c9488bd2bdc1db2749cd4683994a764a44c9 --cloud
Won't Fix
.Disassemble()
feature of supersize console
to see what is going on.Performance-Sheriff
and Performance-Size
.Performance-Sheriff
label.