Google Git
Sign in
chromium / chromium / src / a5a8c6ecf4f93a9b0ba4975416e431af2a4b8827
commita5a8c6ecf4f93a9b0ba4975416e431af2a4b8827[log] [tgz]
authorDanyao Wang <danyao@chromium.org>Mon Nov 27 23:51:34 2017
committerCommit Bot <commit-bot@chromium.org>Mon Nov 27 23:51:34 2017
treeddc7e8d4378406f2b38ea33caa5513a60fb74773
parent2c6527c9da6a46ac90290c8d3e0b97465bf5d0ec [diff]
[Nav Experiment] Restore session history after reenable web usage.

The last use case of SetWebUsageEnabled(false) is to clear visited site
data. It does so by removing the WKWebView due to a bug in WebKit (see
crbug.com/557963). This breaks in WKBasedNavigationManager because it
relies on WKWebView as the source of truth for session history.

This CL fixes the issue by temporarily caching the session history in
WebState and restoring it into the navigation manager when web usage is
re-enabled.

This fixes the LoadIfNecessaryTest.DisableAndReenableWebUsage test.

Bug: 781916
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6f7db84504603e624f5befa66ccb41c10433dd69
Reviewed-on: https://chromium-review.googlesource.com/789791
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519458}
2 files changed
tree: ddc7e8d4378406f2b38ea33caa5513a60fb74773
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .