commit | a6cfb5384bb5950abd16735bda6c2bd96051eb22 | [log] [tgz] |
---|---|---|
author | Avery Musbach <amusbach@chromium.org> | Mon Feb 11 16:58:27 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 11 16:58:27 2019 |
tree | ac74121ae930ea5b90f2fd7e4aca89c829c5da7f | |
parent | 654421aa1725e68e98ee06fd16dfee1dfa111e6d [diff] |
split view: Set |is_resizing_| to false when ending split view. The EndSplitView function contains logic to end resizing, but it does not actually set |is_resizing_| to false. If |is_resizing_| is true, then you can enter split view again and |is_resizing_| will still be true. Issue 930323 probably seems too minor to worry about, but I filed it as an excuse to fix this case which makes the code hard to reason about and is probably responsible for several undiscovered bugs, because it pretty much defeats the purpose of |is_resizing_|. My work on Issue 884930 will be simpler if my logic can rely on |is_resizing_|. Test: ash_unittests SplitViewControllerTest.EndSplitViewWhileDragging Bug: 930323 Change-Id: Iddb5f3d294e38c2e1990abfeff726bb93526609a Reviewed-on: https://chromium-review.googlesource.com/c/1461497 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#630805}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .