commit | a711877ab9ce2b3ed3c82b3594f368e3a3cb75aa | [log] [tgz] |
---|---|---|
author | Luciano Pacheco <lucmult@chromium.org> | Mon Jul 09 03:58:50 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jul 09 03:58:50 2018 |
tree | 395de57a4cbff38b412d4df44a86d7c2e50ff85d | |
parent | 2838dd71b6be5ec2a6dba100038351bcda2f5eb0 [diff] |
Revert "Change error callback to log error" This reverts commit 973eb033820a688aa0aa10160736924bc1fdf13c. Reason for revert: Test became flaky with this CL: crbug.com/860647 Original change's description: > Change error callback to log error > > This callback was just ignoring the error creating an empty result, this > CL changes to log error so it can be identified and fixed. > > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I85c2c4de71742a2d438e30fe75f531750345dc4f > Reviewed-on: https://chromium-review.googlesource.com/1125699 > Commit-Queue: Sasha Morrissey <sashab@chromium.org> > Reviewed-by: Sasha Morrissey <sashab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572875} TBR=sashab@chromium.org,lucmult@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I132067f04aef9055e35678835f703ca51702faf9 Cq-Include-Trybots: luci.chromium.try:closure_compilation But: 860647 Reviewed-on: https://chromium-review.googlesource.com/1128639 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#573210}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .