commit | a72ffe7ee48f23ea1ed43f1f6df967a672112965 | [log] [tgz] |
---|---|---|
author | Yuri Wiitala <miu@chromium.org> | Wed Mar 13 02:33:46 2019 |
committer | Yuri Wiitala <miu@chromium.org> | Wed Mar 13 02:33:46 2019 |
tree | 813b4373ac98a308eee343e08ed88dc201998fbd | |
parent | 342081806e46ebf535b8fa6f39a44054c6f29aef [diff] |
AudioService: Finish SnooperNode tests + timing bug fix. Provides missing testing of key functionality, cleans-up existing tests somewhat to improve readability and robustness, resolves run-time performance issues, and improves debugging facilities. As a result, a timing bug was also discovered and fixed in this change. 😃 1. Added a "dump to WAV file" function, activated via a command-line switch, to aid in confirming test correctness and otherwise debugging future issues. This allows developers to visualize the audio signal with an external editor. 2. By using #1, I came to a better understanding of the sources of timing and resolution error. Thus, certain test issues were better accounted for, and documented in the code. 3. Fixed timing bug in SnooperNode: The recently-added SuggestLatestRenderTime() method needed to also account for the pre- bufferred audio in the resampler. Bug: 934770, 842428 Change-Id: Ieb1638a9cd4b1703ed0325cd6cf365646db6b1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513045 Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640185}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .