)]}' { "commit": "a7606e61e83da06c29dd5a25e10e3fde4acd6737", "tree": "d1129dc0ab75fcd1e71d331a77481fe871d4dbca", "parents": [ "5b1fc679a9efd4909dd2f714b108c73a8465bac6" ], "author": { "name": "Peter Wen", "email": "wnwen@chromium.org", "time": "Mon Nov 06 18:29:02 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Nov 06 18:29:02 2017" }, "message": "Android: Disable findbugs\n\nNow that we have errorprone enabled by default, we get faster static\nanalysis with fewer false positives. Findbugs is no longer necessary.\n\nThis CL also unblocks upgrading errorprone to 2.1.2. The rest of the\nfindbugs annotations and gn args will be removed later.\n\nBUG\u003d777511\n\nCq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet\nChange-Id: I9c32f3773f44a7c58813c0ef6a35a81dc9818178\nReviewed-on: https://chromium-review.googlesource.com/734220\nReviewed-by: agrieve \u003cagrieve@chromium.org\u003e\nReviewed-by: John Budorick \u003cjbudorick@chromium.org\u003e\nReviewed-by: Ken Rockot \u003crockot@chromium.org\u003e\nReviewed-by: Bernhard Bauer \u003cbauerb@chromium.org\u003e\nReviewed-by: Egor Pasko \u003cpasko@chromium.org\u003e\nReviewed-by: Andrei Kapishnikov \u003ckapishnikov@chromium.org\u003e\nCommit-Queue: Peter Wen \u003cwnwen@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#514187}", "tree_diff": [ { "type": "delete", "old_id": "9ca45208ac27e855304d2441111e506b622ccf30", "old_mode": 33261, "old_path": "build/android/findbugs_diff.py", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "d5c4476b7cad2f78cc67081cf2431bee8cfde196", "old_mode": 33188, "old_path": "build/android/findbugs_filter/findbugs_exclude.xml", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "3bab39b255ca36a62e10172c63fef74c58ed9479", "old_mode": 33188, "old_path": "build/android/incremental_install/BUILD.gn", "new_id": "c0bb27e1720ff8411c299560acd83d30fdf466a0", "new_mode": 33188, "new_path": "build/android/incremental_install/BUILD.gn" }, { "type": "delete", "old_id": "05d30faa0034046c3817ff3ea0c1db81277c15e1", "old_mode": 33188, "old_path": "build/android/pylib/utils/findbugs.py", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "01e1c08a82d8e33f012dbd8f6276df8db1bc2b30", "old_mode": 33188, "old_path": "build/config/android/internal_rules.gni", "new_id": "5902ee571644e8a1000996fbf8accee463561d66", "new_mode": 33188, "new_path": "build/config/android/internal_rules.gni" }, { "type": "modify", "old_id": "e32411a22bdc989b1640f3d0f571ff7911db53f2", "old_mode": 33188, "old_path": "components/cronet/android/BUILD.gn", "new_id": "8b4ac7237891e73abe07581ebcb3a584ecd00481", "new_mode": 33188, "new_path": "components/cronet/android/BUILD.gn" }, { "type": "modify", "old_id": "0d0f7014e3b8da978f0ec7b6bf9ea9f9f583ee67", "old_mode": 33188, "old_path": "docs/README.md", "new_id": "8c82c7c4411924cf09c10a589a9f3b95b26135d6", "new_mode": 33188, "new_path": "docs/README.md" }, { "type": "delete", "old_id": "d812118664554664aad4651a63a652c2dde93b9a", "old_mode": 33188, "old_path": "docs/use_find_bugs_for_android.md", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "9b5ed6adc1ed6c6e920f12405dc9679b7c209277", "old_mode": 33188, "old_path": "mojo/public/tools/bindings/mojom.gni", "new_id": "8c80bcf3d31bc7d27c4948d9e2ce45df40ec2235", "new_mode": 33188, "new_path": "mojo/public/tools/bindings/mojom.gni" }, { "type": "modify", "old_id": "c9023920daad280de5c12bb2415a1b50830d5703", "old_mode": 33188, "old_path": "third_party/custom_tabs_client/BUILD.gn", "new_id": "ea188cc7e3d63c24e29bcadd70c1b665b8ceb8bf", "new_mode": 33188, "new_path": "third_party/custom_tabs_client/BUILD.gn" }, { "type": "modify", "old_id": "dcbc8b05ae41c79e06826da95dde13012c6b81a7", "old_mode": 33188, "old_path": "third_party/gif_player/BUILD.gn", "new_id": "7da53c35e91194af7317578431754d19abfcfe2c", "new_mode": 33188, "new_path": "third_party/gif_player/BUILD.gn" }, { "type": "modify", "old_id": "521a81ad72f849a90fb55aad5fdf8e754df4ca5f", "old_mode": 33188, "old_path": "third_party/netty-tcnative/BUILD.gn", "new_id": "d4fd3a97f50a5c3fd45068d81329a49a85524184", "new_mode": 33188, "new_path": "third_party/netty-tcnative/BUILD.gn" }, { "type": "modify", "old_id": "92967f3dd25612346569d3f2b7c6ff3962c6f491", "old_mode": 33188, "old_path": "tools/android/eclipse/.classpath", "new_id": "68b2bfaa0ebc54c775da489a7c69a747052940b2", "new_mode": 33188, "new_path": "tools/android/eclipse/.classpath" }, { "type": "delete", "old_id": "3ba3f53085b9a150da0c8c6bcd0a7fa0bab9e3af", "old_mode": 33188, "old_path": "tools/android/findbugs_plugin/README", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "09ee13c41fd9a4bf3e32bea46c4a7482812ec849", "old_mode": 33188, "old_path": "tools/android/findbugs_plugin/build.xml", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "002e841381af9323d0433e89d5597c7fc31f5aa7", "old_mode": 33188, "old_path": "tools/android/findbugs_plugin/findbugs.xml", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "451566d2e3737dcd59547c41750d486c1752b4fd", "old_mode": 33188, "old_path": "tools/android/findbugs_plugin/lib/chromiumPlugin.jar", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "aea983bc24a5aa7903207fcdd7484d2ccb8242e2", "old_mode": 33188, "old_path": "tools/android/findbugs_plugin/messages.xml", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "d1d7614a1e116140f816ea9e698e7ca9f840227c", "old_mode": 33188, "old_path": "tools/android/findbugs_plugin/src/org/chromium/tools/findbugs/plugin/SynchronizedMethodDetector.java", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "9a4e5e12226c769ef60fdedf165b7999fbfad2aa", "old_mode": 33188, "old_path": "tools/android/findbugs_plugin/src/org/chromium/tools/findbugs/plugin/SynchronizedThisDetector.java", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "ded7848fdc79c6ea08281851f6ba445c6b3ee8bc", "old_mode": 33188, "old_path": "tools/android/findbugs_plugin/test/java/src/org/chromium/tools/findbugs/plugin/SimpleSynchronizedMethod.java", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "d652dbe5101759aea65670225c694cae67b4cf0a", "old_mode": 33188, "old_path": "tools/android/findbugs_plugin/test/java/src/org/chromium/tools/findbugs/plugin/SimpleSynchronizedStaticMethod.java", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "91251559477c014b4739aa3716a05ce15aa52efd", "old_mode": 33188, "old_path": "tools/android/findbugs_plugin/test/java/src/org/chromium/tools/findbugs/plugin/SimpleSynchronizedThis.java", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "603659e6da0ef3825a3e2e99f0c6dceb44d70199", "old_mode": 33261, "old_path": "tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" } ] }