commit a815a65d7776bb43b07d93e458817a0f7694fbe3
author Yao Xiao <yaoxia@chromium.org> Fri Apr 19 06:46:23 2019
committer Commit Bot <commit-bot@chromium.org> Fri Apr 19 06:46:23 2019
tree 0e5bf77d0b658ae66934c9e263f45e066ff72d77
parent 5e89e2ef375757a30335ae515ddc66f5637fc6f7

For service worker, add browser tests to check that the top_frame_origin is null
and the request_initiator is the script origin.

Also fixed 2 issues:
- For the main resource request (serviceWorker.register(...)), it goes through
FrameFetchContext::PrepareRequest() that will always set the top_frame_origin
regardless whether it's from service worker. Adding a check for service worker
seems to fix it.
- The static function GetNetworkFactoryCallbackForTest() in
embedded_worker_instance.cc returns an Optional of Callback, but the caller only
checks the nullity of the Optional but not of the Callback. This sometimes is
causing a crash in the test. Removing the Optional seems to fix it.

Bug: 918868
Change-Id: I2a5b83d8b13b2d52310614dfb5a6dfa4d1cd620a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553948
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652483}