commit | a8b4616feb005d63ab56610efe3798159a66ce7a | [log] [tgz] |
---|---|---|
author | Adam Langley <agl@chromium.org> | Thu Apr 25 02:18:09 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Apr 25 02:18:09 2019 |
tree | ff198cbe3bba29f86a2537351fd9ed03ac60f021 | |
parent | 364b61f8335c6884d9b325c146267b5de4b7a887 [diff] |
device/fido: fix timeouts for BLE devices. It doesn't look like timeouts for BLE devices ever worked: |FidoBleDevice::OnTimeout| would set the state, but that doesn't do anything by itself and the state would be ignored if the callback ever actually happened. In ca2c9afa, a DCHECK was added that caught this in testing (see bug). This change fixes the timeout handling. I don't believe that a similar issue exists for |FidoBleTransaction| because it does trigger its callback on timeout and that callback will delete the |FidoBleTransaction|, thus no more callbacks can enter it. Bug: 955199 Change-Id: Id838ed28946144959534b1a05993557fbf5694d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582274 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#653875}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .