Google Git
Sign in
chromium / chromium / src / a9513c89423fad8554e29ded6a6042fba71c3295
commita9513c89423fad8554e29ded6a6042fba71c3295[log] [tgz]
authorKhushal <khushalsagar@chromium.org>Mon Jun 24 19:49:35 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jun 24 19:49:35 2019
tree7d3795b531591d4783b3a9b513b45a3bbc70a9bf
parent93855739292ddca322f62615fa2d3331de1605a9 [diff]
ui/gl: Gracefully handle failure to schedule the main overlay plane.

Each swap for a surfaceless surface must have at least one overlay plane,
for the OutputSurface, before SwapBuffers is issued. The SurfaceControl
surface assumes this and will crash in SwapBuffers if at least one plane
has not been scheduled.

Crash reports indicate that we have cases where
glScheduleOverlayPlaneCHROMIUM, presumably for the main plane, fails and
we end up crashing during CommitPendingTransaction as a result. Handle
this failure better by reporting a failed swap, which should always lose
the context and recreate the surface.

R=piman@chromium.org

Bug: 977812
Change-Id: I53028e5494d5da39d91d1f685913c46ec9a1bb4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673026
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671757}
2 files changed
tree: 7d3795b531591d4783b3a9b513b45a3bbc70a9bf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .