commit a952353c3720b9cbe100fb6a5b1b1d791e0c5b59
author Kush Sinha <sinhak@chromium.org> Mon Jan 14 16:57:55 2019
committer Commit Bot <commit-bot@chromium.org> Mon Jan 14 16:57:55 2019
tree d80602f57a007b4ab70c13014e1e20468630207d
parent 669fedf5eccf89245da0bc49e25ae6e7d5dac2f5

Fix: crOS Device Account online auth for Secondary Account errors

With Chrome OS Account Manager enabled, if any Secondary Account
requires a re-authentication, it forces the Device Account to require an
online Gaia sign-in at the Chrome OS sign-in screen.

|UserSessionManager| uses |SigninErrorController::HasError()| to check
if the Device Account has a valid token or not. Since Chrome OS didn't
have a concept of Secondary Accounts before, any error in
|SigninErrorController| corresponded to an error in the Device Account.
This assumption in no longer true. |SignErrorController::HasError()| can
return |true| for Secondary Accounts too, and that should not invalidate
the Device Account token.

Fix this by using Identity Service APIs to check for Device Account's
error state.

Bug: 820046
Change-Id: I381e29a38dc284d0e7d27ab942c468ed3d88bf98
Reviewed-on: https://chromium-review.googlesource.com/c/1408449
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622482}