Google Git
Sign in
chromium / chromium / src / a99e831a1256dfe40ee8634181d14667af78d36f
commita99e831a1256dfe40ee8634181d14667af78d36f[log] [tgz]
authorKoji Ishii <kojii@chromium.org>Tue Feb 19 08:42:28 2019
committerCommit Bot <commit-bot@chromium.org>Tue Feb 19 08:42:28 2019
treee846b673823edadbfbde8e7b115139c03babc2fc
parentb2a2d798740664fb584c7a77817385d6579a886d [diff]
[LayoutNG] Avoid creating ShapeResult when collapsing trailing spaces

This patch changes |TruncateLineEndResult| to create truncated
|ShapeResultView| from the original |ShapeResult| in
|NGInlineItem|, not from |ShapeResultView|. Doing so avoids
creating intermediate |ShapeResult|, which saves CPU time and
memory consumed by |RunInfo|.

r632350 (CL:1469846) avoided reshaping when possible, but
|TruncateLineEndResult| needs to create new results even when
reshaping is not needed. This patch should improve both cases,
when reshaping is needed and not needed.

blink_perf.layout:
https://pinpoint-dot-chromeperf.appspot.com/job/139c2aaa340000

Bug: 636993, 931668
Change-Id: Ia60b6c25d52d9999813ef9b37d2f4f38c61ad26a
Reviewed-on: https://chromium-review.googlesource.com/c/1475327
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633215}
1 file changed
tree: e846b673823edadbfbde8e7b115139c03babc2fc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .