commit | 5c3a19671fb71e61899aeb14df7eeac6ca49c9a7 | [log] [tgz] |
---|---|---|
author | Kristi Saney <kristislee@google.com> | Mon Sep 23 22:43:13 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 23 22:43:13 2024 |
tree | 24845289ee47a2b86ead64df37b6508bbebbbbb5 | |
parent | ee4626ad9583b6e5ba899fc5339252df0c494f50 [diff] |
[Read Aloud] Pull notifications into a separate component The previous data binding method was making it difficult to clear the error messages from the language menu once it closed. So instead of putting notification information in app.ts and passing it with data- binding, I created a VoiceNotificationManager to notify listeners of new messages. When the language menu opens, it registers as a listener, and when it's closed, it deregisters. New listeners do get notified of any in-progress downloads though because we always want to show those. This will help with adding the other error messages in other places for these same errors. Fixed: 344036531 Change-Id: I3ec2af438aadb17e4aed18dfe34549b82e369343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5876666 Reviewed-by: Lauren Winston <lwinston@google.com> Commit-Queue: Kristi Saney <kristislee@google.com> Cr-Commit-Position: refs/heads/main@{#1359045}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.