| commit | aae538e62d0ad1b0e5386a598b30f165c48598e7 | [log] [tgz] |
|---|---|---|
| author | Sky Debreuil <skydebreuil@google.com> | Sat Dec 13 03:50:40 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Dec 13 03:50:40 2025 |
| tree | cfa64844897486eacce6e79c2b50f8527d806780 | |
| parent | fbd95064379f4b4762d2bf72d4100fac050a625f [diff] |
Fix delay_layer_tree_view_deletion not getting set in Navigator This patch fixes an issue where `delay_layer_tree_view_deletion` in `ViewTransitionCommitInfo` within `Navigator::DidNavigate` was not being set. It also deletes the default constructor for `ViewTransitionCommitInfo` and add a parameterized constructor to require callers to explicitly provide values for all fields. This ensures that arguments are not missed when constructing the object, preventing bugs where fields rely on unintended default initialization. Update call sites in `Navigator`, `RenderFrameHostManager`, and related tests to use the new constructor syntax. The regression this CL fixes ensures that `RenderFrameHostManager` receives the correct signal to delay layer tree view deletion. Previously, Multi-Page App (MPA) view transitions failed when `AckCopyOutputRequestEarlyForViewTransition` was enabled because this field was left uninitialized, preventing `RenderProcessHost::DelayProcessShutdown` from being called. This regression was likely introduced in crrev.com/c/7205284 during the refactoring of commit info passing. Bug: 468318571 Change-Id: Ifa1234b70533c98206de0b529dc80a90f955411c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7255140 Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Free Debreuil <freedebreuil@google.com> Commit-Queue: Sky Debreuil <skydebreuil@google.com> Auto-Submit: Sky Debreuil <skydebreuil@google.com> Cr-Commit-Position: refs/heads/main@{#1558401}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.