commit | aafff540c0d786f08839b2a7f638f7eed48e047d | [log] [tgz] |
---|---|---|
author | Matt Menke <mmenke@chromium.org> | Mon Apr 22 22:09:36 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Apr 22 22:09:36 2019 |
tree | 6aa909da4b9a893d0ee545d6354c6b08ad280fea | |
parent | 8cc68ad17950074617f8b15154e750a3659a2583 [diff] |
SocketParams refactor 3: Add ClientSocketPool::CreateConnectJob. This new method takes in all the objects needed to create the socket params for a ConnectJob, and then returns a newly created one by invoking the ClientSocketPool::SocketParams callbacks (Which does not actually need all those parameters, as it has a number of them baked in). These parameters include the GroupID, the ProxyServer, and whether or not the socket is for use with websockets. This also required passing in the ProxyServer and websocket information to TransportClientSocketPool, which didn't previously need that information. In a followup CL, I'll make SocketParams no longer a callback, and have the method do some of what ClientSocketPoolMaager does. Bug: 533571 Change-Id: Ie9113ec941f5db3363255bf27a113841d1b30377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562613 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652971}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .