commit abc1fd51abe85756c0b872a8920d94aea0b033d6
author Peter Kasting <pkasting@chromium.org> Sun Mar 17 20:36:20 2019
committer Commit Bot <commit-bot@chromium.org> Sun Mar 17 20:36:20 2019
tree bfc63fb90ce3c248b9a6f793bd762907eb00d854
parent 107efba2a9a4e4cc4028736411debe92c797ae72

Split GetFirstFocusableView() into two pieces and eliminate magic -1.

This is clearer to understand and facilitates later conversion to iterators.  It
also makes it more possible to change forward and backward searching to behave
distinctly, which we may want to fix bug 942358.

This makes one behavior change: GetNextFocusedView(.., false) will now be
willing to return parent views where the child was the first child.  This is
symmetric with the "forward" behavior, makes more sense in the abstract, and I
believe was simply an artifact of the original code trying to avoid overloading
the meaning of "-1" (which would have meant "check all children" when this
callsite meant "check no children").  I did not think deeply through how this
change would affect callers in practice.

Bug: 942358
Change-Id: Ie25208878db4e61dea2b39c6628575959c037544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525159
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641490}