commit | ac3b9467bbec3664370e339a77d4c26574808abb | [log] [tgz] |
---|---|---|
author | Antonio Gomes <tonikitoo@igalia.com> | Fri Dec 13 20:05:24 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Dec 13 20:05:24 2024 |
tree | b00fc45dc2afe9e4401c61aa28eb6b87fe567b3b | |
parent | c7cd1af796578956ade58ccb39e7dec0f164286f [diff] |
Remove FirstRunService::EntryPoint enum Originally, the idea was to remove only two menu items, `kWebAppLaunch` and `kWebAppContextMenu`, since they were relevant in the context of Lacros, which has been terminated. However, dgn@ suggested that we remove the enum altogether, given that the remaining items would become pointless and only server for histogram logging. This CL removes the enum altogether, as a follow up of [1]. Additionally, it removes the related histogram declaration, since it was really intended to track the usage of the Lacros entrypoints, and the usage for Dice was not really important. Last, it also remove DICE build guards from the touched files. [1] https://crrev.com/c/6074493 R=dgn@chromium.org, hidehiko@chromium.org, neis@chromium.org Bug: 373971535, 382086296 OBSOLETE_HISTOGRAM[ProfilePicker.FirstRun.EntryPoint]=Deprecated in M133 - Unneeded now that Lacros support is removed. Change-Id: Ie824c28aefa8ded572aad9c0f77449f7b140d297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088160 Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1396122}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.