commit | adea757803c1d0bb50fc9c5642b1cb28807e53a0 | [log] [tgz] |
---|---|---|
author | Colin Blundell <blundell@chromium.org> | Tue Jul 24 09:26:32 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jul 24 09:26:32 2018 |
tree | 01b645176aff580cbe55fe09638bd75d21d1b679 | |
parent | 2923be5550076c6d78b7514340b796bf7278b7b8 [diff] |
Eliminate SigninClient::AddCookieChangeCallback() While working on GaiaCookieManagerService, I noticed that SigninClient::AddCookieChangeCallback() is unnecessary to call out to the embedder for: the only embedder-specific parameterization of the //components-level SigninCookieChangeSubscription is for the URLRequestContextGetter, which is already available to the component via SigninClient::GetURLRequestContext(). This CL eliminates that client method in favor of having GaiaCookieManagerService construct SigninCookieChangeSubscription directly. I verified that all production clients were supplying the same URLRequestContextGetter that they return in their implementation of SigninClient::GetURLRequestContext(). TBR=jzw@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic8a9d0c6e3e63cf531408eb6ab46db65bcf3e668 Reviewed-on: https://chromium-review.googlesource.com/1145312 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#577467}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .