| commit | ae3f21431bdb7e03f17d98a63a3909843a6dbe21 | [log] [tgz] |
|---|---|---|
| author | Theo Johnson-Kanu <tjohnsonkanu@google.com> | Fri May 07 21:41:39 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 07 21:41:39 2021 |
| tree | fe20293e3c7ca187b517aeda6b5e092b3468c50d | |
| parent | 1166b787560cac603b273aadc21cab799232eefd [diff] |
[CrOS cellular] update start scanning button width Before this CL start scanning button width was small in languages like German, resulting in text being two lined. This CL increases the width of start scanning button and updates use camera again text. Screenshot: https://screenshot.googleplex.com/52x3U5R4ttwgjHb.png https://screenshot.googleplex.com/7QzcQmDNZ8L3yVY.png Bug: 1203543 Change-Id: Ib3c216d4e0238d7ad24fd55204f45421f0fb79e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2880879 Reviewed-by: Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#880570}
diff --git a/chrome/app/chromeos_strings.grdp b/chrome/app/chromeos_strings.grdp index f659159..ab39e8d 100644 --- a/chrome/app/chromeos_strings.grdp +++ b/chrome/app/chromeos_strings.grdp
@@ -337,7 +337,7 @@ Activation code detected </message> <message name="IDS_CELLULAR_SETUP_ESIM_PAGE_SCAN_QR_CODE_USE_CAMERA_AGAIN" desc="Label for button informing the user to click to use the camera to rescan for QR codes."> - use camera again + Use camera again </message> <message name="IDS_CELLULAR_SETUP_ESIM_PAGE_SCAN_QR_CODE_ERROR" desc="Label informing the user that there was an error detecting activation code."> Error detecting code
diff --git a/chrome/app/chromeos_strings_grdp/IDS_CELLULAR_SETUP_ESIM_PAGE_SCAN_QR_CODE_USE_CAMERA_AGAIN.png.sha1 b/chrome/app/chromeos_strings_grdp/IDS_CELLULAR_SETUP_ESIM_PAGE_SCAN_QR_CODE_USE_CAMERA_AGAIN.png.sha1 index bd84a3ad..fad07d1 100644 --- a/chrome/app/chromeos_strings_grdp/IDS_CELLULAR_SETUP_ESIM_PAGE_SCAN_QR_CODE_USE_CAMERA_AGAIN.png.sha1 +++ b/chrome/app/chromeos_strings_grdp/IDS_CELLULAR_SETUP_ESIM_PAGE_SCAN_QR_CODE_USE_CAMERA_AGAIN.png.sha1
@@ -1 +1 @@ -770be185e26dd97739b50680a9ea92f977e7b1e2 \ No newline at end of file +3ca968f6f61bfaeb331f150257e6adea3c975d30 \ No newline at end of file
diff --git a/ui/webui/resources/cr_components/chromeos/cellular_setup/activation_code_page.html b/ui/webui/resources/cr_components/chromeos/cellular_setup/activation_code_page.html index e4801a8..62f5983 100644 --- a/ui/webui/resources/cr_components/chromeos/cellular_setup/activation_code_page.html +++ b/ui/webui/resources/cr_components/chromeos/cellular_setup/activation_code_page.html
@@ -174,6 +174,13 @@ #pageBody { margin-top: -20px; } + + #startScanningButton { + max-width: 470px; + min-width: 345px; + text-align: center; + width: auto; + } </style> <base-page> <div slot="page-body" id="pageBody" class="animate">
