commit | ae4c925722db751de02c0d317ab6797b73eca530 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Wed Oct 03 21:31:32 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 03 21:31:32 2018 |
tree | aac6922faa3a2d3833be5a4e262f4532ff8b27fd | |
parent | 07e0c65c7b6b076fb2c3baefe19ef7451db9071f [diff] |
Removing unused private field from Windows NSSDecryptor Coding standard and compiler do not like unused private fields, but sometimes they slip between the cracks until they trigger something: In file included from gen/chrome/utility/utility_jumbo_1.cc:12: In file included from .\../../chrome/utility/importer/firefox_importer.cc:26: In file included from ../..\chrome/utility/importer/nss_decryptor.h:13: ../..\chrome/utility/importer/nss_decryptor_win.h(169,29): error: private field 'PK11_CheckUserPassword' is not used [-Werror,-Wunused-private-field] PK11CheckUserPasswordFunc PK11_CheckUserPassword; ^ 1 error generated. This removes the unsued field. Also removing an "explicit" to get past presubmit checks. Running presubmit upload checks ... L: \src\clean_chromium\src\chrome\utility\importer\nss_decryptor_win.cc:18: Zero-parameter constructors should not be marked explicit. [runtime/explicit] [5] Change-Id: Id310c0f65a406c1a47ec29312472580d15dfd1ce Reviewed-on: https://chromium-review.googlesource.com/c/1259018 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596375}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .