commit | aed9bea08cc73d338b33d2e84d2c5431ed55cefd | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Sat Apr 20 02:30:09 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Apr 20 02:30:09 2019 |
tree | a751deedb639b6163f0a99b3fc8141f62b49c8f1 | |
parent | c599cb459d8e61a7251bc0368ab971977e2a520f [diff] |
Change enum Version to enum class Version It is possible to accidentally call the Windows GetVersion() function when base::win::GetVersion() is intended. The code would compile due to implicit conversions from enum to int. This allowed buggy code to be checked in. Using enum class makes this error impossible. This change switches enum Version to enum class Version, which includes changing every usage of the Version enum. For services\service_manager TBR=wfh@chromium.org For the rest TBR=jochen@chromium.org Bug: 946677 Change-Id: I4b446370499e5e6a24446d18b541e2b4948405e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541594 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652728}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .