tree d8ff37ccd4387a77d9631b265e509aec2090447a
parent 04d80b5db7f3d2f9518c44b40bf4704e6fcd2eec
author Kentaro Hara <haraken@chromium.org> 1534477851 +0000
committer Commit Bot <commit-bot@chromium.org> 1534477851 +0000

Revert "[Mac] Moved TextSuggestionsTouchBarController's Range Validity Check"

This reverts commit 8fd04b5fbba25e412874ff15c659c25fb9dcc12c.

Reason for revert: TextSuggestionsTouchBarControllerTest.InvalidRange started failing

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28606

Original change's description:
> [Mac] Moved TextSuggestionsTouchBarController's Range Validity Check
> 
> Previously, -updateTextSelection:range:offset: could receive an invalid
> range from WebContentsTextObserver::DidChangeTextSelection(). This
> invalid range would then cause a crash in -requestSuggestions.
> 
> A check has been added to -updateTextSelection:range:offset: to make
> sure that a selection with an invalid range is not passed to
> -requestSuggestions. This should prevent future crashes.
> 
> TextSuggestionsTouchBarControllerTest.InvalidRange tests that an
> invalid range does not crash the controller and is handled
> properly.
> 
> Bug: 717553
> Change-Id: I69f49cb1f1819e1d528837767dfb894d8652e84d
> Reviewed-on: https://chromium-review.googlesource.com/1178467
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Sarah Chan <spqchan@chromium.org>
> Commit-Queue: Tessa Nijssen <tnijssen@google.com>
> Cr-Commit-Position: refs/heads/master@{#583815}

TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com

Change-Id: I7735c373052037bb377c1beac79d7b1132f3bc86
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 717553
Reviewed-on: https://chromium-review.googlesource.com/1179382
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583954}