commit | b0b8a00545700cc8ea7014ed6dd6fae198581423 | [log] [tgz] |
---|---|---|
author | Henrik Boström <hbos@chromium.org> | Wed Jan 04 10:11:54 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 04 10:11:54 2023 |
tree | b3180c6b92ecb6855bfd889ea992f94b5bd10273 | |
parent | ad4734a8d921ed84940849a69d616e25454515c3 [diff] |
[macOS] Migrate to AVCapturePhotoOutput for ImageCapture.takePhoto(). AVCaptureStillImageOutput is deprecated, in preparation for its future removal migrate to AVCapturePhotoOutput which is only available on macOS 10.15. In order not to break backwards-compat, the old API is still used as a fallback. To avoid takePhoto() returning empty data in the event of multiple pending takePhoto() calls, the logic for handling pending photos is simplified: take as many photos as requested, but one at a time. This means we only need a single variable to keep track of pending photos (_pendingTakePhotos). To test both the new and old path, TEST_P is used. TESTED=https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html Bug: chromium:1124322 Change-Id: I802c80ebb06677d2309ca804b39a2d8703f548ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4128918 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/main@{#1088642}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.