Google Git
Sign in
chromium / chromium / src / b0b9e8a10021168b09ea0d37523aae6c3626bad7
commitb0b9e8a10021168b09ea0d37523aae6c3626bad7[log] [tgz]
authorchuanl <chuanl@google.com>Wed Feb 20 23:41:23 2019
committerCommit Bot <commit-bot@chromium.org>Wed Feb 20 23:41:23 2019
tree7f1e94c902ab71a2c9febca2b8b1555314f4f5f4
parentb5d5438413e13affdbcf05b25a1f548a9476463e [diff]
Revert CCT header customization when dynamic module fails to load.

For the benefit of a consistent UI, CCT header customization is
immediately allowed when module loading is started. When module loading
fails, we should revert any customization incurred during module
loading. However, this is not happening prior to this CL because
maybeCustomizeCctHeader() becomes no-op when module fails to load.

We are also using the same criteria as used by CloseButtonNavigator to
determine when to customize the header.

Bug: 882404
Change-Id: Id58d80abf7cea8ecea0fccdf7f85ebe28970ec6d
Reviewed-on: https://chromium-review.googlesource.com/c/1437086
Commit-Queue: John Lin <chuanl@google.com>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633949}
3 files changed
tree: 7f1e94c902ab71a2c9febca2b8b1555314f4f5f4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .