commit | b117c3202ed77ed13e450819e608b647da6fc4b1 | [log] [tgz] |
---|---|---|
author | Eugene But <eugenebut@google.com> | Mon Jan 07 21:00:28 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jan 07 21:00:28 2019 |
tree | 2c73c76ce8795c556b2a15e0d2db450a82d8db36 | |
parent | 5b061f846eb18add758c5dbfe263fcce59c08408 [diff] |
Remove -[TabModel navigationCommittedInTab:previousItem:]. The body of the method was simplified and merged into the caller. Most of the old code was related to calculation of "is in-page navigation" boolean flag, which is actually present in LoadCommittedDetails. New code simply uses LoadCommittedDetails.is_in_page flag. The motivation for the change is to eventually replace didCommitNavigationWithDetails with didFinishNavigation. didFinishNavigation does not provide "previous navigation item" pointer, which was used in the old code. Bug: 661983 Change-Id: Ida8ffa4c1127a2750be642e29bb86e90d42dfad9 Reviewed-on: https://chromium-review.googlesource.com/c/1396451 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#620466}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .