Build: generated_types needs to explicitly depend on base
json_scheme_api generated_types template includes generated code
that uses files like base/logging.h and base/values.h so targets
need to depend on //base or gn dependency checks will be unhappy.
Bug: 938893
Change-Id: Ib36220775a03d77dbb5076aa4df9c8291121b967
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518516
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640027}diff --git a/tools/json_schema_compiler/json_schema_api.gni b/tools/json_schema_compiler/json_schema_api.gni
index 6529482f..07cded3 100644
--- a/tools/json_schema_compiler/json_schema_api.gni
+++ b/tools/json_schema_compiler/json_schema_api.gni
@@ -269,7 +269,10 @@
# Compute the contents of the library/source set.
lib_sources = invoker.sources + get_target_outputs(":$schema_generator_name")
lib_public_deps = [ ":$schema_generator_name" ]
- lib_deps = [ "//tools/json_schema_compiler:generated_api_util" ]
+ lib_deps = [
+ "//base",
+ "//tools/json_schema_compiler:generated_api_util",
+ ]
lib_extra_configs = [ "//build/config/compiler:no_size_t_to_int_warning" ]
if (defined(invoker.configs)) {
lib_extra_configs += invoker.configs
