Migrate DeprecatedLower to LowerASCII where only compared with ASCII

This CL changes DeprecatedLower calls to LowerASCII where the result
is only ever used in a comparison against one or more ASCII constants
(including predicates like StartsWith) but is otherwise dead, and I
believe it’s the last CL needed to finish our intent to remove Unicode
case-insensitivity for ASCII constants [1].

The correctness of the image_encoder_utils.cc change isn’t obvious,
but you can verify it by heading to the line in Chromium Code Search
[2], hovering over lowercase_mime_type, and observing that the only
reads are == MIME type literals and by two functions:

• IsSupportedImageMIMETypeForEncoding (line 78), which does the same
• ParseImageEncodingMimeType (line 80), which does the same

These changes are potentially author-facing, except where the constant
in question contains none of {s,k,S,K} [3], but I’ve optimistically
made them without any additional tests based on Rick Byers’ reasoning
on blink-dev [4]. Please let me know if that’s not sufficient here.

[1] https://groups.google.com/a/chromium.org/d/topic/blink-dev/sFOpNuQ91UU
[2] https://source.chromium.org/chromium/chromium/src/+/f7455871a37e53362183771af7de36844df73a38:third_party/blink/renderer/platform/image-encoders/image_encoder_utils.cc;l=36
[3] https://www.unicode.org/Public/UCD/latest/ucd/CaseFolding.txt
[4] https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ

Change-Id: I10e621bb2a6947bc3004d9a0c156dcae2e05a6e8
Bug: 627682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114510
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753581}
6 files changed
tree: 06e3ca35129128819c499c7a19b19489e60fe76e
  1. .clang-format
  2. .clang-tidy
  3. .eslintrc.js
  4. .git-blame-ignore-revs
  5. .gitattributes
  6. .gitignore
  7. .gn
  8. .vpython
  9. .vpython3
  10. .yapfignore
  11. AUTHORS
  12. BUILD.gn
  13. CODE_OF_CONDUCT.md
  14. DEPS
  15. ENG_REVIEW_OWNERS
  16. LICENSE
  17. LICENSE.chromium_os
  18. OWNERS
  19. PRESUBMIT.py
  20. PRESUBMIT_test.py
  21. PRESUBMIT_test_mocks.py
  22. README.md
  23. WATCHLISTS
  24. android_webview/
  25. apps/
  26. ash/
  27. base/
  28. build/
  29. build_overrides/
  30. buildtools/
  31. cc/
  32. chrome/
  33. chromecast/
  34. chromeos/
  35. cloud_print/
  36. codereview.settings
  37. components/
  38. content/
  39. courgette/
  40. crypto/
  41. dbus/
  42. device/
  43. docs/
  44. extensions/
  45. fuchsia/
  46. gin/
  47. google_apis/
  48. google_update/
  49. gpu/
  50. headless/
  51. infra/
  52. ios/
  53. ipc/
  54. jingle/
  55. media/
  56. mojo/
  57. native_client_sdk/
  58. net/
  59. pdf/
  60. ppapi/
  61. printing/
  62. remoting/
  63. rlz/
  64. sandbox/
  65. services/
  66. skia/
  67. sql/
  68. storage/
  69. styleguide/
  70. testing/
  71. third_party/
  72. tools/
  73. ui/
  74. url/
  75. weblayer/
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.