Google Git
Sign in
chromium / chromium / src / b20bb048913985eae71b480db2a2017173ef73a2
commitb20bb048913985eae71b480db2a2017173ef73a2[log] [tgz]
authorerikchen <erikchen@chromium.org>Thu Jul 12 20:16:25 2018
committerCommit Bot <commit-bot@chromium.org>Thu Jul 12 20:16:25 2018
treec7427a6cf3915ab6357ada78d57d26775a5e2b9e
parent4b937d53836386e51532fbe870938b33ce0455ed [diff]
Remove assertion from DetachToOwnWindow on macOS 10.10.

On macOS 10.10, AppKit appears to use the test's generated events to
asynchronously reactivate the first window. There's no way to tell when this
asynchronous reactivation will happen, so just avoid checking the assertion in
the test. This problem appears constrained to how we generate test events, and
not to the actual behavior of Chrome.

Bug: 862859
Change-Id: Ibab56946bef3aea9aac3123d3d8aefdb7974d063
Reviewed-on: https://chromium-review.googlesource.com/1135305
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574699}
1 file changed
tree: c7427a6cf3915ab6357ada78d57d26775a5e2b9e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .