Google Git
Sign in
chromium / chromium / src / b215a0895e0253ba829eb665459030d8b2f4234b
commitb215a0895e0253ba829eb665459030d8b2f4234b[log] [tgz]
authorRohit Rao <rohitrao@chromium.org>Tue Jul 17 16:21:06 2018
committerCommit Bot <commit-bot@chromium.org>Tue Jul 17 16:21:06 2018
tree515530bd4136f16c71f77b3ee8c4e126061ab9d8
parentf0ef986d5fa3a34abaf9731ed933c028bb5bcee2 [diff]
[ios] Fixes a crash when displaying the downloads UI after a side swipe.

During a side swipe to change tabs, we remove the content area from the
view hierarchy.  This was causing issues with the downloads UI, as we
were attempting to set up constraints before the view hierarchy was
reassembled.  This CL swaps the order of calls to
sideSwipeViewDismissAnimationDidEnd and setCurrentTab, to ensure that
the view hierarchy is fully reassembled before any of the tab change
machinery is invoked.

BUG=849827

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iba2642f949a10d1a31ed32ae3763fed244022fdf
Reviewed-on: https://chromium-review.googlesource.com/1138351
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575664}
1 file changed
tree: 515530bd4136f16c71f77b3ee8c4e126061ab9d8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .