Google Git
Sign in
chromium / chromium / src / b32ae43ec080625156769457e0dd705d3a54c7b8
commitb32ae43ec080625156769457e0dd705d3a54c7b8[log] [tgz]
authorMatt Falkenhagen <falken@chromium.org>Mon Mar 04 04:41:40 2019
committerCommit Bot <commit-bot@chromium.org>Mon Mar 04 04:41:40 2019
treec004d4f11b8d2efd749bf9152fd084015dea508c
parente590d4e0ae6d3cbdabee199ea6fabe152a3eea83 [diff]
service worker: Bind Mojo interfaces using the WorkerThread's task runner.

Attempted fix for the linked bugs. Based on crash reports, it appears
some Mojo calls are happening on the wrong thread or on the service
worker thread after it's started being destructed/terminated. To try
to fix this, explicitly bind the interfaces using the WorkerThread's
task runner, which seems to have guarantees about safely dropping
tasks when the worker thread starts being destructed/terminated.

Bug: 927149, 907311, 934622
Change-Id: I4d8e59ada9cd28aa22039fbbb77f5aa0d149ff28
Reviewed-on: https://chromium-review.googlesource.com/c/1496264
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637204}
8 files changed
tree: c004d4f11b8d2efd749bf9152fd084015dea508c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .