Google Git
Sign in
chromium / chromium / src / b3bf64e2aa498d39ee246c7183dd7c1f17f5f3f6
commitb3bf64e2aa498d39ee246c7183dd7c1f17f5f3f6[log] [tgz]
authorElly Fong-Jones <ellyjones@chromium.org>Tue Nov 13 19:19:28 2018
committerCommit Bot <commit-bot@chromium.org>Tue Nov 13 19:19:28 2018
treef95394b27a26e9f1b2965b0ab29265ad3ae9053d
parentb903c3070dcb045d64722ef8d738d171e66bf241 [diff]
views: close menus when accelerators are pressed on Mac

This change:

1) Has MenuController consider command to be an accelerator key, along with
   control and alt, for the purpose of not searching for mnemonics;
2) Adds a Mac override of ViewsDelegate::ProcessAcceleratorWhileMenuShowing
   which tells the menu to close for an accelerator

Bug: 885138
Change-Id: Iee9d9abb3b1bb3c2d346d7aaf7e532866b4ad26a
Reviewed-on: https://chromium-review.googlesource.com/c/1334147
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607699}
3 files changed
tree: f95394b27a26e9f1b2965b0ab29265ad3ae9053d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .