commit | b5b0faec5370a2fcc889228dc4719b1289c21394 | [log] [tgz] |
---|---|---|
author | Friedrich Horschig <fhorschig@chromium.org> | Thu May 23 09:13:43 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu May 23 09:13:43 2019 |
tree | a1c3beba9d8a85facf287d930219e2e9e1d25290 | |
parent | 1142cd35df53f44e202826c29a4589cbcd6e422e [diff] |
[Mfill Android] Fix ViewPager timing issues The ViewPager has timing issues that surface if any bottom sheet is invoked very, very quickly after its creation. I witnessed this approximately 1 out of 30 times when testing manually and approximately 1 in 5 times in automated tests. As far as I know, this test flakiness wasn't reported yet and the most affected test has yet to land. This CL posts a SetCurrentItem call right after it's regularly called. That way, if there are no async issues, it will work as it should. But if another SetCurrentItem marks the wrong item active, it will be overridden very soon after. Visually, the difference can (afaict) only be perceived during the very first opening _if_ the wrong sheet would trigger. The flickering is not perceivable unless expected (since the sheet is still opening at the moment when the switch happens). Bug: None Change-Id: I2dcd7ab329746efed6aff294f2dbdb5657357a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624816 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#662545}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .