Google Git
Sign in
chromium / chromium / src / b6146df6674befc5c7013516e2909c2f36d44c14
commitb6146df6674befc5c7013516e2909c2f36d44c14[log] [tgz]
authorMohamed Amir Yosef <mamir@chromium.org>Thu May 16 14:52:08 2019
committerCommit Bot <commit-bot@chromium.org>Thu May 16 14:52:08 2019
treedd7a48ff49a21303daaf4f4ef04e51fd5d4a80fb
parenta24746f1c8c5089547e6f5643942cee7908ed1d5 [diff]
[Sync::USS] Don't populate client tags for bookmark tombstones

Before this CL:
NonBlockingTypeCommitContribution used to populate the client
defined unique tag for bookmark tombstones with an empty string. This
is because it used the check if specifics has bookmarks to identify
the bookmark commits. However, for tombstones, specifics are empty and
hence the check fails.

After this CL:
The model type is plumbed through and checked explicitly instead of
checking the specifics.

In addition, this CL also makes sure the client tag isn't populated for
Nigori data type.

Bug: 963895
Change-Id: I2c04e758fc341f92cd3ffe46b38579b5d98fead6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615202
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660389}
3 files changed
tree: dd7a48ff49a21303daaf4f4ef04e51fd5d4a80fb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .