commit | b83cbaf00f9e293005fe78713bd5f12e96cd4b07 | [log] [tgz] |
---|---|---|
author | Joanmarie Diggs <jdiggs@igalia.com> | Wed May 31 18:37:13 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 31 18:37:13 2023 |
tree | 2c3e9f026e004e0642712eb83bdd3a53b3d0398c | |
parent | 5464ca8520ff082104dbfec47eca8127419ce036 [diff] |
Revert "Handle nodeless break opportunities in AXPosition::FromPosition" This reverts commit 62bb11dfc61d7b9af789ffa6d3c4feca8dcfca81. Reason for revert: We are hitting a DCHECK (see bug 1450024). Original change's description: > Handle nodeless break opportunities in AXPosition::FromPosition > > The accessible text exposed to assistive technologies comes from the > InlineTextBox content; characters representing break opportunities are > excluded. > > If the break opportunity has an associated node, such as <wbr>, > AXPosition is able to connect that character's content offsets > with the "ignored" accessibility object, and ensure the text offsets > exposed to ATs correspond to the accessible text. It needs to do the > same for break opportunities which lack an associated node, such as > those inserted at the end of preserved leading spaces. > > Create AXPosition::AdjustContentOffsetForNonContiguousMappings which > identifies nodeless break opportunities and adjusts the accessible > content offset accordingly. > > AX-Relnotes: Screen readers should no longer present the wrong character > during caret navigation if "white-space: pre-wrap" is applied to an > element with leading spaces. > > Bug: 1442835 > Change-Id: I914d051b942dcd50de55674816e32cfbf578e5a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4543184 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> > Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#1150216} Bug: 1442835 Change-Id: Ib83e7802083788c1465243c6d3e5e1f0f2e939b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577058 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1151386}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.