commit | b969b739bc98312834daa07785cb8e18ccc4bcfc | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Wed Feb 20 16:52:32 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 20 16:52:32 2019 |
tree | abf5204c09d75bf872fcca2628a0e658985bd71b | |
parent | 2d8ae68be2d86c950be3c4362a1bb444e5d28a6e [diff] |
Remove variable shadowing in blink/modules/notifications In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact error this avoids is: third_party/blink/renderer/modules/notifications/notification_data.cc:93:45: error: declaration shadows a local variable [-Werror,-Wshadow] SerializedScriptValue::SerializeOptions options; ^ ./../../third_party/blink/renderer/modules/notifications/notification_data.cc:43:32: note: previous declaration is here const NotificationOptions* options, ^ Bug: 923510 Change-Id: Ie49096ef30fbab30567ad45f3f2d8b76a8eab9ed Reviewed-on: https://chromium-review.googlesource.com/c/1478891 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#633744}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .