Google Git
Sign in
chromium / chromium / src / b99c9c1e25ba8663a7f4b5a3970dc836591be24f
commitb99c9c1e25ba8663a7f4b5a3970dc836591be24f[log] [tgz]
authorPiotr Bialecki <bialpio@chromium.org>Fri Jun 14 23:03:24 2019
committerCommit Bot <commit-bot@chromium.org>Fri Jun 14 23:03:24 2019
tree3b5407ffbaf141287bf2f01c551072c6f4accc99
parentd4410a3561ce51cf965cb3d558f7cd3b6d273b0b [diff]
Revert "Fix module install"

This reverts commit 801cc00b4ec48cfcfbbd48a441d59d48892f7c48.

Reason for revert: The commit causes crashes on startup (assertion failure) when running on debug builds.

801cc00b4ec4 Fix module install - crashes on startup
05c5bcb74e2a Do not block logon hours for AD accounts - works (parent of 801cc00b4ec4)

Original change's description:
> Fix module install
> 
> Previously, we created a SplitInstallManager _before_ calling
> SplitCompat.install(-), which breaks the module install flow on Android
> pre-Q.
> 
> Bug: b/133669491
> Change-Id: I0b317732ed364a592047eeb7387c74dd1ea1b258
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646903
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#668416}

TBR=cjgrant@chromium.org,tiborg@chromium.org,fredmello@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/133669491
Change-Id: Id3918e90582b68034cef643279c18f8be6c5cecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661209
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669420}
2 files changed
tree: 3b5407ffbaf141287bf2f01c551072c6f4accc99
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .