)]}' { "commit": "bcb319044e002362613784a7659f63349314523c", "tree": "33de3834d7a4b2aa370ca91f0681bf94bbfa1c60", "parents": [ "138b630edcba439fb7bb38db60e0519226d94da8" ], "author": { "name": "Rakina Zata Amni", "email": "rakina@chromium.org", "time": "Fri Apr 19 23:02:05 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri Apr 19 23:02:05 2019" }, "message": "[Display Locking]: Highlight highest locked ancestor instead of highlighting nodes in locked subtree\n\nPreviously DevTools might call getBoundingClientRect on nodes in a\nlocked subtree from within paint, which might trigger style/layout\nbecause we skipped the locked subtree in those phases (so they\nmight be still dirty), leading to crashes.\n\nFor nodes in a locked subtree, when we want to highlight it, we\nshould instead highlight the highest locked ancestor instead,\nbecause it will always have up-to-date style \u0026 layout values.\nThe tooltip for the overlay will indicate that we\u0027re highlighting\nthe locked ancestor in that case.\nSee https://bugs.chromium.org/p/chromium/issues/detail?id\u003d934458#c12\nfor a screenshot of the UI.\n\nBug: 934458\nChange-Id: I20d85104cbeed36af6ac98b157ab6da31ed73dc3\nReviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528123\nReviewed-by: Dmitry Gozman \u003cdgozman@chromium.org\u003e\nReviewed-by: vmpstr \u003cvmpstr@chromium.org\u003e\nCommit-Queue: Rakina Zata Amni \u003crakina@chromium.org\u003e\nCr-Commit-Position: refs/heads/master@{#652682}", "tree_diff": [ { "type": "modify", "old_id": "2d65b82afacc3e5fa35ca4f047eb0e2db08dc86f", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/display_lock/display_lock_utilities.cc", "new_id": "11d0f453f582b9d8517c11e6ffedcd6269cc39c2", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/display_lock/display_lock_utilities.cc" }, { "type": "modify", "old_id": "186f74a90131bad03b5db3ae79339a39470262d0", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/display_lock/display_lock_utilities.h", "new_id": "20b5989529eb86f7606a4cb0b9c1dc2a39d1aaf9", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/display_lock/display_lock_utilities.h" }, { "type": "modify", "old_id": "a068c151df388d7219b4df2264992176458a1775", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/inspector/inspect_tool_highlight.html", "new_id": "f7bcae8e1cb11eec72fa88a349f74e3b844f745f", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/inspector/inspect_tool_highlight.html" }, { "type": "modify", "old_id": "e877a487ffcb6c2fc1c6cb87dfab8efdbda12026", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/inspector/inspect_tools.cc", "new_id": "0d3048dc40f02daa8c55b5a636f8fd216440a1a8", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/inspector/inspect_tools.cc" }, { "type": "modify", "old_id": "0068747322be13b98f68bd6e2672ccbb7f6ca1c3", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/inspector/inspect_tools.h", "new_id": "2bc42c57baf18b419b3c308c6913f62488688b05", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/inspector/inspect_tools.h" }, { "type": "modify", "old_id": "7844e84a7ef6303979f604c8622dd4ea813f9ebe", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/inspector/inspector_highlight.cc", "new_id": "6ee202590cad617fa008dc766065ab0f497108ef", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/inspector/inspector_highlight.cc" }, { "type": "modify", "old_id": "2f91d696d7843cbff4f19e589c5ebb205982a415", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/inspector/inspector_highlight.h", "new_id": "4667ea98d90beb82d87395f88d772866193216f5", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/inspector/inspector_highlight.h" }, { "type": "modify", "old_id": "9d86d8eb262aa202ccc9a7abb0d585f8058fe421", "old_mode": 33188, "old_path": "third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc", "new_id": "ec5a47a2bdbef0d4b10e3efe3b84612cf85e465a", "new_mode": 33188, "new_path": "third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc" }, { "type": "modify", "old_id": "4ee1ffd3c93258fa1475736599c05a638700b239", "old_mode": 33188, "old_path": "third_party/blink/web_tests/TestExpectations", "new_id": "c47d0b7fed56dbd2239a030b5e095bda04b1fae5", "new_mode": 33188, "new_path": "third_party/blink/web_tests/TestExpectations" }, { "type": "modify", "old_id": "da2fe524651080ab81af2e749ea7f30c35dd6cfb", "old_mode": 33188, "old_path": "third_party/blink/web_tests/VirtualTestSuites", "new_id": "30b66d2c6eb8f621424e4ca974f8cf399e31133b", "new_mode": 33188, "new_path": "third_party/blink/web_tests/VirtualTestSuites" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "2f4d666736ab75ddbf39210993ae382d74f2de52", "new_mode": 33188, "new_path": "third_party/blink/web_tests/http/tests/devtools/elements/highlight/highlight-display-locked.js" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "2f3fd5bcaeb554fd440bc9a00c9e76dac8959f69", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/display-lock/http/tests/devtools/elements/highlight/README.txt" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "149252b9d53aae24cc8262945d4847443f62be91", "new_mode": 33188, "new_path": "third_party/blink/web_tests/virtual/display-lock/http/tests/devtools/elements/highlight/highlight-display-locked-expected.txt" } ] }